redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[AVR32] ext int fixes

Browse source 
Bugfixes for external irq handler set_irq_type():

 - If set_irq_type() can't set the type, don't change anything!

 - It's not OK to change the flow handler as part of set_irq_type(),
   among other issues that violates spinlock rules.  Instead, we can
   call the relevant handler when we demux the external interrupts.

 - The external irq demux has no need to grab the spinlock.  And in
   fact grabbing it that way was wrong, since that code might be
   pre-empted by an irq at a different priority level, and that code
   might then have tried to grab that spinlock...

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
This commit is contained in:
David Brownell 2007-01-23 20:21:36 -08:00 committed by Haavard Skinnemoen
parent a3d912c8fa
commit 58febc0b13
1 changed files with 17 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
arch/avr32/mach-at32ap/extint.c
View file

@ -55,20 +55,11 @@ static int eim_set_irq_type(unsigned int irq, unsigned int flow_type)
unsigned long flags; unsigned long flags;
int ret = 0; int ret = 0;
flow_type &= IRQ_TYPE_SENSE_MASK;
if (flow_type == IRQ_TYPE_NONE) if (flow_type == IRQ_TYPE_NONE)
flow_type = IRQ_TYPE_LEVEL_LOW; flow_type = IRQ_TYPE_LEVEL_LOW;
desc = &irq_desc[irq]; desc = &irq_desc[irq];
desc->status &= ~(IRQ_TYPE_SENSE_MASK | IRQ_LEVEL);
desc->status |= flow_type & IRQ_TYPE_SENSE_MASK;
if (flow_type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH)) {
desc->status |= IRQ_LEVEL;
set_irq_handler(irq, handle_level_irq);
} else {
set_irq_handler(irq, handle_edge_irq);
}
spin_lock_irqsave(&sm->lock, flags); spin_lock_irqsave(&sm->lock, flags);
mode = sm_readl(sm, EIM_MODE); mode = sm_readl(sm, EIM_MODE);
@ -97,9 +88,16 @@ static int eim_set_irq_type(unsigned int irq, unsigned int flow_type)
break; break;
} }
sm_writel(sm, EIM_MODE, mode); if (ret == 0) {
sm_writel(sm, EIM_EDGE, edge); sm_writel(sm, EIM_MODE, mode);
sm_writel(sm, EIM_LEVEL, level); sm_writel(sm, EIM_EDGE, edge);
sm_writel(sm, EIM_LEVEL, level);
if (flow_type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
flow_type |= IRQ_LEVEL;
desc->status &= ~(IRQ_TYPE_SENSE_MASK | IRQ_LEVEL);
desc->status |= flow_type;
}
spin_unlock_irqrestore(&sm->lock, flags); spin_unlock_irqrestore(&sm->lock, flags);
@ -122,8 +120,6 @@ static void demux_eim_irq(unsigned int irq, struct irq_desc *desc)
unsigned long status, pending; unsigned long status, pending;
unsigned int i, ext_irq; unsigned int i, ext_irq;
spin_lock(&sm->lock);
status = sm_readl(sm, EIM_ISR); status = sm_readl(sm, EIM_ISR);
pending = status & sm_readl(sm, EIM_IMR); pending = status & sm_readl(sm, EIM_IMR);
@ -133,10 +129,11 @@ static void demux_eim_irq(unsigned int irq, struct irq_desc *desc)
ext_irq = i + sm->eim_first_irq; ext_irq = i + sm->eim_first_irq;
ext_desc = irq_desc + ext_irq; ext_desc = irq_desc + ext_irq;
ext_desc->handle_irq(ext_irq, ext_desc); if (ext_desc->status & IRQ_LEVEL)
handle_level_irq(ext_irq, ext_desc);
else
handle_edge_irq(ext_irq, ext_desc);
} }
spin_unlock(&sm->lock);
} }
static int __init eim_init(void) static int __init eim_init(void)
@ -168,8 +165,9 @@ static int __init eim_init(void)
sm->eim_chip = &eim_chip; sm->eim_chip = &eim_chip;
for (i = 0; i < nr_irqs; i++) { for (i = 0; i < nr_irqs; i++) {
/* NOTE the handler we set here is ignored by the demux */
set_irq_chip_and_handler(sm->eim_first_irq + i, &eim_chip, set_irq_chip_and_handler(sm->eim_first_irq + i, &eim_chip,
handle_edge_irq); handle_level_irq);
set_irq_chip_data(sm->eim_first_irq + i, sm); set_irq_chip_data(sm->eim_first_irq + i, sm);
} }