redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drm/vboxvideo: Make structure vbox_fb_helper_funcs constant 

The static structure vbox_fb_helper_funcs, of type drm_fb_helper_funcs,
is used only when it is passed as the third argument to
drm_fb_helper_fbdev_setup(), which does not modify it. Hence make it
constant to protect it from unintended modifications.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190813062548.24770-1-nishkadg.linux@gmail.com
alistair/sunxi64-5.4-dsi
Nishka Dasgupta 2019-08-13 11:55:48 +05:30 committed by Hans de Goede
parent f2cb60e9a3
commit 596cb85218
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/vboxvideo/vbox_drv.c
View File

@ -32,7 +32,7 @@ static const struct pci_device_id pciidlist[] = {
};
MODULE_DEVICE_TABLE(pci, pciidlist);
static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
.fb_probe = vboxfb_create,
};