redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

powerpc: Fix boot wrapper memcmp() called with zero length argument 

I noticed, when trying to use, e.g.,
node = find_node_by_prop_value(prev, "booleanprop", "", 0))
to search for all nodes with a certain boolean property, that memcmp()
returns garbage when comparing zero bytes.  It should return zero.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
hifive-unleashed-5.1
Mike Ditto 2008-10-17 09:27:51 +00:00 committed by Benjamin Herrenschmidt
parent e81703724a
commit 59fd6b8cc0
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/powerpc/boot/string.S
View File

@ -235,7 +235,7 @@ memchr:
.globl memcmp
memcmp:
cmpwi 0,r5,0
blelr
ble 2f
mtctr r5
addi r6,r3,-1
addi r4,r4,-1
@ -244,6 +244,8 @@ memcmp:
subf. r3,r0,r3
bdnzt 2,1b
blr
2: li r3,0
blr
/*