redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

HID: wacom: leds: make sure Cintiq 21UX2 and 24HD control the right LEDs

Browse source 
The code for 21UX2 and 24HD makes the LED group 1 on the left, and
the group 0 on the right. The buttons are ordered in the other way,
but libwacom already exports those that way. So we simply can't reassign
LED group 0 to the left buttons, and have to quirk the incoming data...

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: Ping Cheng <pingc@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Benjamin Tissoires 2016-07-13 18:06:13 +02:00 committed by Jiri Kosina
parent 34736aa96e
commit 5a0fe8abd1
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/hid/wacom_wac.c
View file

@ -2768,6 +2768,15 @@ static bool wacom_is_led_toggled(struct wacom *wacom, int button_count,
{
int button_per_group;
/*
* 24HD and 21UX2 have LED group 1 to the left and LED group 0
* to the right. We need to reverse the group to match this
* historical behavior.
*/
if (wacom->wacom_wac.features.type == WACOM_24HD ||
wacom->wacom_wac.features.type == WACOM_21UX2)
group = 1 - group;
button_per_group = button_count/wacom->led.count;
return mask & (1 << (group * button_per_group));