redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[media] ngene: preventing dereferencing a NULL pointer

Browse source 
As reported by smatch:
	drivers/media/pci/ngene/ngene-core.c:1529 init_channel() error: we previously assumed 'chan->fe' could be null (see line 1521)

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Mauro Carvalho Chehab 2015-04-28 10:02:07 -03:00
parent f8781a0820
commit 5a4faee2d0
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/media/pci/ngene/ngene-core.c
View file

@ -1526,10 +1526,12 @@ static int init_channel(struct ngene_channel *chan)
if (chan->fe2) { if (chan->fe2) {
if (dvb_register_frontend(adapter, chan->fe2) < 0) if (dvb_register_frontend(adapter, chan->fe2) < 0)
goto err; goto err;
chan->fe2->tuner_priv = chan->fe->tuner_priv; if (chan->fe) {
memcpy(&chan->fe2->ops.tuner_ops, chan->fe2->tuner_priv = chan->fe->tuner_priv;
&chan->fe->ops.tuner_ops, memcpy(&chan->fe2->ops.tuner_ops,
sizeof(struct dvb_tuner_ops)); &chan->fe->ops.tuner_ops,
sizeof(struct dvb_tuner_ops));
}
} }
if (chan->has_demux) { if (chan->has_demux) {