redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

MLK-21865 Revert "regmap: use debugfs even when no device" 

This reverts commit 9b947a13e7.

The commit 9b947a13e7 does not consider power and
clock when expose the regmap into debugsfs. This may bring some problem for some
case. E.g., For reset registers (not real GPR, but csi bridge register) for
MIPI DSI, MIPI CSI and LCDIF on i.mx8mm, they only can be accessed after the
disp_root clock and dispmix power has been turned on, otherwise the system may
be stuck.

on i.mx8mm evk, the command to reproduce (with default dtb, no display/capture
running):
cat /sys/kernel/debug/regmap/dummy-display-gpr@32e28000/registers

This patch reverted previous commit to avoid the exposure.

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: Fancy Fang <chen.fang@nxp.com>
5.4-rM2-2.2.x-imx-squashed
Robby Cai 2019-05-27 15:47:15 +08:00 committed by Fancy Fang
parent 57e0cc9da1
commit 5af6d5eaf4
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/base/regmap/regmap.c
View File

@ -1148,8 +1148,6 @@ skip_format_initialization:
ret = regmap_attach_dev(dev, map, config);
if (ret != 0)
goto err_regcache;
} else {
regmap_debugfs_init(map, config->name);
}
return map;