redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[SCSI] remove spurious if tests from scsi_eh_{times_out|done} 

'if' tests which check if eh_action isn't NULL in both
functions are always true.  Remove the redundant if's as it
can give wrong impressions.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
hifive-unleashed-5.1
Tejun Heo 2005-05-14 00:46:18 +09:00 committed by James Bottomley
parent 0155a37ea5
commit 5b8ef84258
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/scsi/scsi_error.c
View File

@ -434,8 +434,7 @@ static void scsi_eh_times_out(struct scsi_cmnd *scmd)
SCSI_LOG_ERROR_RECOVERY(3, printk("%s: scmd:%p\n", __FUNCTION__,
scmd));
if (scmd->device->host->eh_action)
up(scmd->device->host->eh_action);
up(scmd->device->host->eh_action);
}
/**
@ -457,8 +456,7 @@ static void scsi_eh_done(struct scsi_cmnd *scmd)
SCSI_LOG_ERROR_RECOVERY(3, printk("%s scmd: %p result: %x\n",
__FUNCTION__, scmd, scmd->result));
if (scmd->device->host->eh_action)
up(scmd->device->host->eh_action);
up(scmd->device->host->eh_action);
}
}