redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

xfs: always return with the iolock held from xfs_file_aio_write_checks 

While xfs_iunlock is fine with 0 lockflags the calling conventions are much
cleaner if xfs_file_aio_write_checks never returns without the iolock held.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
hifive-unleashed-5.1
Christoph Hellwig 2011-12-18 20:00:13 +00:00 committed by Ben Myers
parent 2813d682e8
commit 5bf1f26227
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fs/xfs/xfs_file.c
View File

@ -636,7 +636,9 @@ out_lock:
/*
* Common pre-write limit and setup checks.
*
* Returns with iolock held according to @iolock.
* Called with the iolocked held either shared and exclusive according to
* @iolock, and returns with it held. Might upgrade the iolock to exclusive
* if called for a direct write beyond i_size.
*/
STATIC ssize_t
xfs_file_aio_write_checks(
@ -653,8 +655,7 @@ xfs_file_aio_write_checks(
restart:
error = generic_write_checks(file, pos, count, S_ISBLK(inode->i_mode));
if (error) {
xfs_rw_iunlock(ip, XFS_ILOCK_EXCL | *iolock);
*iolock = 0;
xfs_rw_iunlock(ip, XFS_ILOCK_EXCL);
return error;
}