redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drivers: of: Fix of_pci.h header guard 

The compilation of of_pci.c is governed by CONFIG_OF_PCI, but the
corresponding declarations in of_pci.h are inconsistently guarded by
CONFIG_OF, with the result that if CONFIG_PCI is disabled for an OF
platform, the dangling external declarations are still active and the
inline stub definitions not. So far this has managed to go unnoticed
since it happens that the only references to these functions are from
code which itself depends on CONFIG_PCI or CONFIG_OF_PCI.

Fix this with the appropriate config guard so that any new callers
outside PCI-specific code don't start unexpectedly breaking under
certain configs.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
hifive-unleashed-5.1
Robin Murphy 2016-06-07 18:44:48 +01:00 committed by Rob Herring
parent 3eefa7e8cc
commit 5c1d3310d8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/linux/of_pci.h
View File

@ -8,7 +8,7 @@ struct pci_dev;
struct of_phandle_args;
struct device_node;
#ifdef CONFIG_OF
#ifdef CONFIG_OF_PCI
int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq);
struct device_node *of_pci_find_child_device(struct device_node *parent,
unsigned int devfn);