1
0
Fork 0

crypto: ccree - improve kerneldoc in cc_request_mgr.[ch]

Miscellaneous improvements:
  - Start comment blocks with "/**" to enable kerneldoc,
  - Mark parameters using "@" instead of "\param",
  - Fix copied is_dout parameter of cc_send_request(),
  - Add missing function names to kerneldoc headers,
  - Add missing parameter descriptions.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
alistair/sensors
Geert Uytterhoeven 2020-02-11 19:19:21 +01:00 committed by Herbert Xu
parent dc16c9f764
commit 5c68361f57
2 changed files with 31 additions and 29 deletions

View File

@ -206,12 +206,13 @@ static void enqueue_seq(struct cc_drvdata *drvdata, struct cc_hw_desc seq[],
} }
} }
/*! /**
* Completion will take place if and only if user requested completion * request_mgr_complete() - Completion will take place if and only if user
* by cc_send_sync_request(). * requested completion by cc_send_sync_request().
* *
* \param dev * @dev: Device pointer
* \param dx_compl_h The completion event to signal * @dx_compl_h: The completion event to signal
* @dummy: unused error code
*/ */
static void request_mgr_complete(struct device *dev, void *dx_compl_h, static void request_mgr_complete(struct device *dev, void *dx_compl_h,
int dummy) int dummy)
@ -264,15 +265,15 @@ static int cc_queues_status(struct cc_drvdata *drvdata,
return -ENOSPC; return -ENOSPC;
} }
/*! /**
* Enqueue caller request to crypto hardware. * cc_do_send_request() - Enqueue caller request to crypto hardware.
* Need to be called with HW lock held and PM running * Need to be called with HW lock held and PM running
* *
* \param drvdata * @drvdata: Associated device driver context
* \param cc_req The request to enqueue * @cc_req: The request to enqueue
* \param desc The crypto sequence * @desc: The crypto sequence
* \param len The crypto sequence length * @len: The crypto sequence length
* \param add_comp If "true": add an artificial dout DMA to mark completion * @add_comp: If "true": add an artificial dout DMA to mark completion
* *
*/ */
static void cc_do_send_request(struct cc_drvdata *drvdata, static void cc_do_send_request(struct cc_drvdata *drvdata,
@ -486,16 +487,18 @@ int cc_send_sync_request(struct cc_drvdata *drvdata,
return 0; return 0;
} }
/*! /**
* Enqueue caller request to crypto hardware during init process. * send_request_init() - Enqueue caller request to crypto hardware during init
* assume this function is not called in middle of a flow, * process.
* Assume this function is not called in the middle of a flow,
* since we set QUEUE_LAST_IND flag in the last descriptor. * since we set QUEUE_LAST_IND flag in the last descriptor.
* *
* \param drvdata * @drvdata: Associated device driver context
* \param desc The crypto sequence * @desc: The crypto sequence
* \param len The crypto sequence length * @len: The crypto sequence length
* *
* \return int Returns "0" upon success * Return:
* Returns "0" upon success
*/ */
int send_request_init(struct cc_drvdata *drvdata, struct cc_hw_desc *desc, int send_request_init(struct cc_drvdata *drvdata, struct cc_hw_desc *desc,
unsigned int len) unsigned int len)

View File

@ -12,18 +12,17 @@
int cc_req_mgr_init(struct cc_drvdata *drvdata); int cc_req_mgr_init(struct cc_drvdata *drvdata);
/*! /**
* Enqueue caller request to crypto hardware. * cc_send_request() - Enqueue caller request to crypto hardware.
* *
* \param drvdata * @drvdata: Associated device driver context
* \param cc_req The request to enqueue * @cc_req: The request to enqueue
* \param desc The crypto sequence * @desc: The crypto sequence
* \param len The crypto sequence length * @len: The crypto sequence length
* \param is_dout If "true": completion is handled by the caller * @req: Asynchronous crypto request
* If "false": this function adds a dummy descriptor completion
* and waits upon completion signal.
* *
* \return int Returns -EINPROGRESS or error * Return:
* Returns -EINPROGRESS or error
*/ */
int cc_send_request(struct cc_drvdata *drvdata, struct cc_crypto_req *cc_req, int cc_send_request(struct cc_drvdata *drvdata, struct cc_crypto_req *cc_req,
struct cc_hw_desc *desc, unsigned int len, struct cc_hw_desc *desc, unsigned int len,