redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

IB/rxe: Don't check for null ptr in send() 

pkt->qp was already dereferenced earlier in the function.

Fixes Smatch complaint:
drivers/infiniband/sw/rxe/rxe_net.c:458 send()
	 warn: variable dereferenced before check 'pkt->qp' (see line 441)

Signed-off-by: Andrew Boyer <andrew.boyer@dell.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
hifive-unleashed-5.1
Andrew Boyer 2016-12-22 08:54:38 -05:00 committed by Doug Ledford
parent cbf1f9a46c
commit 5cc8fabc5e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/infiniband/sw/rxe/rxe_net.c
View File

@ -459,8 +459,7 @@ static int send(struct rxe_dev *rxe, struct rxe_pkt_info *pkt,
return -EAGAIN;
}
if (pkt->qp)
atomic_inc(&pkt->qp->skb_out);
atomic_inc(&pkt->qp->skb_out);
kfree_skb(skb);
return 0;