drm/msm: fix potential memleak in error branch
[ Upstream commit 177d381963
]
In function msm_submitqueue_create, the queue is a local
variable, in return -EINVAL branch, queue didn`t add to ctx`s
list yet, and also didn`t kfree, this maybe bring in potential
memleak.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
[trivial commit msg fixup]
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
5.4-rM2-2.2.x-imx-squashed
parent
f608a77e0c
commit
5d6891a5a6
|
@ -71,8 +71,10 @@ int msm_submitqueue_create(struct drm_device *drm, struct msm_file_private *ctx,
|
||||||
queue->flags = flags;
|
queue->flags = flags;
|
||||||
|
|
||||||
if (priv->gpu) {
|
if (priv->gpu) {
|
||||||
if (prio >= priv->gpu->nr_rings)
|
if (prio >= priv->gpu->nr_rings) {
|
||||||
|
kfree(queue);
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
queue->prio = prio;
|
queue->prio = prio;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue