redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

libceph: avoid a use-after-free during map check 

Sending map check after complete_request() was called is not only
useless, but can lead to a use-after-free as req->r_kref decrement in
__complete_request() races with map check code.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
hifive-unleashed-5.1
Ilya Dryomov 2018-05-22 16:26:51 +02:00
parent 29e878201e
commit 6001567c14
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/ceph/osd_client.c
View File

@ -2266,7 +2266,7 @@ again:
complete_request(req, err);
mutex_unlock(&osd->lock);
if (ct_res == CALC_TARGET_POOL_DNE)
if (!err && ct_res == CALC_TARGET_POOL_DNE)
send_map_check(req);
if (promoted)