redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

scsi: target: iscsi: calling iscsit_stop_session() inside iscsit_close_session() has no effect

Browse source 
iscsit_close_session() can only be called when nconn is zero (otherwise a
kernel panic is triggered). If nconn is zero then iscsit_stop_session()
does nothing and exits, so calling it makes no sense.

We still need to call iscsit_check_session_usage_count() because this
function will sleep if the session's refcount is not zero and we don't want
to destroy the session structure if it's still being referenced.

Link: https://lore.kernel.org/r/20200313170656.9716-4-mlombard@redhat.com
Tested-by: Rahul Kundu <rahul.kundu@chelsio.com>
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Maurizio Lombardi 2020-03-13 18:06:56 +01:00 committed by Martin K. Petersen
parent 57c46e9f33
commit 626bac7337
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/target/iscsi/iscsi_target.c
View file

@ -4381,8 +4381,7 @@ int iscsit_close_session(struct iscsi_session *sess)
* restart the timer and exit. * restart the timer and exit.
*/ */
if (!in_interrupt()) { if (!in_interrupt()) {
if (iscsit_check_session_usage_count(sess) == 1) iscsit_check_session_usage_count(sess);
iscsit_stop_session(sess, 1, 1);
} else { } else {
if (iscsit_check_session_usage_count(sess) == 2) { if (iscsit_check_session_usage_count(sess) == 2) {
atomic_set(&sess->session_logout, 0); atomic_set(&sess->session_logout, 0);