redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

cifs: smbd: Indicate to retry on transport sending failure 

Failure to send a packet doesn't mean it's a permanent failure, it can't be
returned to user process. This I/O should be retried or failed based on
server packet response and transport health. This logic is handled by the
upper layer.

Give this decision to upper layer.

Signed-off-by: Long Li <longli@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
hifive-unleashed-5.2
Long Li 2019-04-05 21:36:33 +00:00 committed by Steve French
parent 98e0d40888
commit 62fdf6707e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/cifs/smbdirect.c
View File

@ -853,7 +853,7 @@ static int smbd_create_header(struct smbd_connection *info,
if (info->transport_status != SMBD_CONNECTED) {
log_outgoing(ERR, "disconnected not sending\n");
return -ENOENT;
return -EAGAIN;
}
atomic_dec(&info->send_credits);
@ -979,6 +979,7 @@ static int smbd_post_send(struct smbd_connection *info,
wake_up(&info->wait_send_pending);
}
smbd_disconnect_rdma_connection(info);
rc = -EAGAIN;
} else
/* Reset timer for idle connection after packet is sent */
mod_delayed_work(info->workqueue, &info->idle_timer_work,
@ -2085,7 +2086,7 @@ int smbd_send(struct TCP_Server_Info *server, struct smb_rqst *rqst)
int rc;
if (info->transport_status != SMBD_CONNECTED) {
rc = -ENODEV;
rc = -EAGAIN;
goto done;
}