redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

watchdog: mei_wdt: no need to check return value of debugfs_create functions 

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Tomas Winkler <tomas.winkler@intel.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
alistair/sunxi64-5.4-dsi
Greg Kroah-Hartman 2019-06-18 17:58:30 +02:00 committed by Wim Van Sebroeck
parent 1dbb3bb8de
commit 64079cf9f2
1 changed files with 7 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
drivers/watchdog/mei_wdt.c
View File

@ -537,38 +537,23 @@ static void dbgfs_unregister(struct mei_wdt *wdt)
wdt->dbgfs_dir = NULL;
}
static int dbgfs_register(struct mei_wdt *wdt)
static void dbgfs_register(struct mei_wdt *wdt)
{
struct dentry *dir, *f;
struct dentry *dir;
dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
if (!dir)
return -ENOMEM;
wdt->dbgfs_dir = dir;
f = debugfs_create_file("state", S_IRUSR, dir, wdt, &dbgfs_fops_state);
if (!f)
goto err;
f = debugfs_create_file("activation", S_IRUSR,
dir, wdt, &dbgfs_fops_activation);
if (!f)
goto err;
debugfs_create_file("state", S_IRUSR, dir, wdt, &dbgfs_fops_state);
return 0;
err:
dbgfs_unregister(wdt);
return -ENODEV;
debugfs_create_file("activation", S_IRUSR, dir, wdt,
&dbgfs_fops_activation);
}
#else
static inline void dbgfs_unregister(struct mei_wdt *wdt) {}
static inline int dbgfs_register(struct mei_wdt *wdt)
{
return 0;
}
static inline void dbgfs_register(struct mei_wdt *wdt) {}
#endif /* CONFIG_DEBUG_FS */
static int mei_wdt_probe(struct mei_cl_device *cldev,
@ -621,8 +606,7 @@ static int mei_wdt_probe(struct mei_cl_device *cldev,
if (ret)
goto err_disable;
if (dbgfs_register(wdt))
dev_warn(&cldev->dev, "cannot register debugfs\n");
dbgfs_register(wdt);
return 0;