redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

btrfs: send: replace check with an assert in gen_unique_name 

The buffer passed to snprintf can hold the fully expanded format string,
64 = 3x largest ULL + 3x char + trailing null.  I don't think that removing the
check entirely is a good idea, hence the ASSERT.

Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Josef Bacik <jbacik@fb.com>
hifive-unleashed-5.1
David Sterba 2014-02-03 18:24:09 +01:00 committed by Josef Bacik
parent 5ed7f9ff15
commit 64792f2535
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/btrfs/send.c
View File

@ -1418,11 +1418,7 @@ static int gen_unique_name(struct send_ctx *sctx,
while (1) {
len = snprintf(tmp, sizeof(tmp), "o%llu-%llu-%llu",
ino, gen, idx);
if (len >= sizeof(tmp)) {
/* should really not happen */
ret = -EOVERFLOW;
goto out;
}
ASSERT(len < sizeof(tmp));
di = btrfs_lookup_dir_item(NULL, sctx->send_root,
path, BTRFS_FIRST_FREE_OBJECTID,