drivers/net/ehea: Remove redundant test
In each case, vpage is checked not to be NULL just after it is initialized at the beginning of each loop iteration. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; expression E; position p1,p2; @@ if (x@p1 == NULL || ...) { ... when forall return ...; } ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) ( x@p2 == NULL | x@p2 != NULL ) // another path to the test that is not through p1? @s exists@ local idexpression r.x; position r.p1,r.p2; @@ ... when != x@p1 ( x@p2 == NULL | x@p2 != NULL ) @fix depends on !s@ position r.p1,r.p2; expression x,E; statement S1,S2; @@ ( - if ((x@p2 != NULL) || ...) S1 | - if ((x@p2 == NULL) && ...) S1 | - BUG_ON(x@p2 == NULL); ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
b0fd0d235d
commit
662f44af63
|
@ -182,7 +182,7 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter,
|
|||
goto out_kill_hwq;
|
||||
}
|
||||
} else {
|
||||
if ((hret != H_PAGE_REGISTERED) || (!vpage)) {
|
||||
if (hret != H_PAGE_REGISTERED) {
|
||||
ehea_error("CQ: registration of page failed "
|
||||
"hret=%lx\n", hret);
|
||||
goto out_kill_hwq;
|
||||
|
@ -303,7 +303,7 @@ struct ehea_eq *ehea_create_eq(struct ehea_adapter *adapter,
|
|||
goto out_kill_hwq;
|
||||
|
||||
} else {
|
||||
if ((hret != H_PAGE_REGISTERED) || (!vpage))
|
||||
if (hret != H_PAGE_REGISTERED)
|
||||
goto out_kill_hwq;
|
||||
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue