redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

V4L/DVB: pvrusb2: Avoid using stack allocated buffers when performing USB I/O

Browse source 
Drivers shouldn't assume that the stack is DMA-safe.

[mchehab@redhat.com: fix patch description]
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mike Isely 2010-05-15 00:09:47 -03:00 committed by Mauro Carvalho Chehab
parent c641a18969
commit 6861800c15
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/media/video/pvrusb2/pvrusb2-hdw.c
View file

@ -4084,12 +4084,20 @@ void pvr2_hdw_device_reset(struct pvr2_hdw *hdw)
void pvr2_hdw_cpureset_assert(struct pvr2_hdw *hdw,int val)
{
char da[1];
char *da;
unsigned int pipe;
int ret;
if (!hdw->usb_dev) return;
da = kmalloc(16, GFP_KERNEL);
if (da == NULL) {
pvr2_trace(PVR2_TRACE_ERROR_LEGS,
"Unable to allocate memory to control CPU reset");
return;
}
pvr2_trace(PVR2_TRACE_INIT,"cpureset_assert(%d)",val);
da[0] = val ? 0x01 : 0x00;
@ -4103,6 +4111,8 @@ void pvr2_hdw_cpureset_assert(struct pvr2_hdw *hdw,int val)
"cpureset_assert(%d) error=%d",val,ret);
pvr2_hdw_render_useless(hdw);
}
kfree(da);
}