redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ieee1394: Fix kthread stopping in nodemgr_host_thread 

The nodemgr host thread can exit on its own even when kthread_should_stop
is not true, on receiving a signal (might never happen in practice, as
it ignores signals). But considering kthread_stop() must not be mixed with
kthreads that can exit on their own, I think changing the code like this
is clearer. This change means the thread can cut its sleep short when
receive a signal but looking at the code around, that sounds okay (and
again, it might never actually recieve a signal in practice).

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
hifive-unleashed-5.1
Satyam Sharma 2007-08-15 20:05:38 +05:30 committed by Stefan Richter
parent 261b5f664c
commit 69e2b60296
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/ieee1394/nodemgr.c
View File

@ -1712,7 +1712,8 @@ static int nodemgr_host_thread(void *__hi)
* to make sure things settle down. */
g = get_hpsb_generation(host);
for (i = 0; i < 4 ; i++) {
if (msleep_interruptible(63) || kthread_should_stop())
msleep_interruptible(63);
if (kthread_should_stop())
goto exit;
/* Now get the generation in which the node ID's we collect