redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: bcm2835-audio: Add TODO list

Browse source 
Add a TODO list of possible cleanup items.

Signed-off-by: Michael Zoran <mzoran@crowfest.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Michael Zoran 2017-01-29 06:39:09 -08:00 committed by Greg Kroah-Hartman
parent 60d5c020bb
commit 6c07499d63
1 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
drivers/staging/bcm2835-audio/TODO Normal file
View file

@ -0,0 +1,29 @@
*****************************************************************************
* *
* TODO: BCM2835-AUDIO *
* *
*****************************************************************************
1) Document the device tree node
The downstream tree(the tree that the driver was imported from) at
http://www.github.com/raspberrypi/linux uses this node:
audio: audio {
compatible = "brcm,bcm2835-audio";
brcm,pwm-channels = <8>;
};
Since the driver requires the use of VCHIQ, it may be useful to have a link
in the device tree to the VCHIQ driver.
2) Gracefully handle the case where VCHIQ is missing from the device tree or
it has not been initialized yet.
3) Review error handling and remove duplicate code.
4) Cleanup the logging mechanism. The driver should probably be using the
standard kernel logging mechanisms such as dev_info, dev_dbg, and friends.
5) Fix the remaining checkpatch.pl errors and warnings.