redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

mlx5/core: Use memdup_user() rather than duplicating its implementation

Browse source 
* Reuse existing functionality from memdup_user() instead of keeping
  duplicate source code.

  This issue was detected by using the Coccinelle software.

* Return directly if this copy operation failed.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Markus Elfring 2016-08-20 07:50:09 +02:00 committed by David S. Miller
parent b9a24bb76b
commit 6f0b826da4
1 changed files with 3 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
drivers/net/ethernet/mellanox/mlx5/core/cmd.c
View file

@ -1015,7 +1015,6 @@ static ssize_t data_write(struct file *filp, const char __user *buf,
struct mlx5_core_dev *dev = filp->private_data;
struct mlx5_cmd_debug *dbg = &dev->cmd.dbg;
void *ptr;
int err;
if (*pos != 0)
return -EINVAL;
@ -1023,25 +1022,15 @@ static ssize_t data_write(struct file *filp, const char __user *buf,
kfree(dbg->in_msg);
dbg->in_msg = NULL;
dbg->inlen = 0;
ptr = kzalloc(count, GFP_KERNEL);
if (!ptr)
return -ENOMEM;
if (copy_from_user(ptr, buf, count)) {
err = -EFAULT;
goto out;
}
ptr = memdup_user(buf, count);
if (IS_ERR(ptr))
return PTR_ERR(ptr);
dbg->in_msg = ptr;
dbg->inlen = count;
*pos = count;
return count;
out:
kfree(ptr);
return err;
}
static ssize_t data_read(struct file *filp, char __user *buf, size_t count,