redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

of/unittest: early return from test skips tests 

Fix bugs pointed out by checkpatch: Mis-coding of two if statements
caused early return from function.

Number of tests completed increased from 102 to 107.
Number of tests failed increased from 0 to 2.

Signed-off-by: Frank Rowand <frank.rowand@sonymobile.com>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
hifive-unleashed-5.1
Frank Rowand 2015-03-13 23:57:40 -07:00 committed by Grant Likely
parent c8547119ce
commit 716e1d493a
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/of/unittest.c
View File

@ -782,12 +782,14 @@ static void __init of_selftest_platform_populate(void)
irq = platform_get_irq(pdev, 0);
selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq);
if (selftest(np = of_find_node_by_path("/testcase-data/platform-tests"),
"No testcase data in device tree\n"));
np = of_find_node_by_path("/testcase-data/platform-tests");
selftest(np, "No testcase data in device tree\n");
if (!np)
return;
if (selftest(!(rc = device_register(&test_bus)),
"testbus registration failed; rc=%i\n", rc));
rc = device_register(&test_bus);
selftest(!rc, "testbus registration failed; rc=%i\n", rc);
if (rc)
return;
for_each_child_of_node(np, child) {