redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

blk-mq-debugfs: don't open code strstrip() 

Slightly more readable, plus we also strip leading spaces.

Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
hifive-unleashed-5.1
Omar Sandoval 2017-05-04 00:31:26 -07:00 committed by Jens Axboe
parent c7e4145ae1
commit 71b90511cb
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
block/blk-mq-debugfs.c
View File

@ -111,17 +111,16 @@ static ssize_t blk_queue_flags_store(struct file *file, const char __user *buf,
size_t count, loff_t *ppos) size_t count, loff_t *ppos)
{ {
struct request_queue *q = file_inode(file)->i_private; struct request_queue *q = file_inode(file)->i_private;
char op[16] = { }, *s; char opbuf[16] = { }, *op;
if (count >= sizeof(op)) { if (count >= sizeof(opbuf)) {
pr_err("%s: operation too long\n", __func__); pr_err("%s: operation too long\n", __func__);
goto inval; goto inval;
} }
if (copy_from_user(op, buf, count)) if (copy_from_user(opbuf, buf, count))
return -EFAULT; return -EFAULT;
s = op; op = strstrip(opbuf);
strsep(&s, " \t\n"); /* strip trailing whitespace */
if (strcmp(op, "run") == 0) { if (strcmp(op, "run") == 0) {
blk_mq_run_hw_queues(q, true); blk_mq_run_hw_queues(q, true);
} else if (strcmp(op, "start") == 0) { } else if (strcmp(op, "start") == 0) {