redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

RDMA/qedr: Fix uABI structure layouts for 32/64 compat 

struct qedr_alloc_ucontext_resp is a different length in 32 and 64
bit compiles due to implicit compiler padding.

The structs alloc_pd_uresp, create_cq_uresp and create_qp_uresp are
not padded by the compiler, but in user space the compiler pads them
due to the way the core and driver structs are concatenated. Make
this padding explicit and consistent for future sanity.

The kernel driver can already handle the user buffer being smaller
than required and copies correctly, so no compat or ABI break happens
from introducing the explicit padding.

Acked-by: Michal Kalderon <michal.kalderon@cavium.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
hifive-unleashed-5.1
Jason Gunthorpe 2018-03-20 14:19:48 -06:00
parent 611cb92b08
commit 71e80a4781
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/uapi/rdma/qedr-abi.h
View File

@ -53,6 +53,7 @@ struct qedr_alloc_ucontext_resp {
__u8 dpm_enabled;
__u8 wids_enabled;
__u16 wid_count;
__u32 reserved;
};
struct qedr_alloc_pd_ureq {
@ -61,6 +62,7 @@ struct qedr_alloc_pd_ureq {
struct qedr_alloc_pd_uresp {
__u32 pd_id;
__u32 reserved;
};
struct qedr_create_cq_ureq {
@ -71,6 +73,7 @@ struct qedr_create_cq_ureq {
struct qedr_create_cq_uresp {
__u32 db_offset;
__u16 icid;
__u16 reserved;
};
struct qedr_create_qp_ureq {
@ -105,6 +108,7 @@ struct qedr_create_qp_uresp {
__u16 rq_icid;
__u32 rq_db2_offset;
__u32 reserved;
};
#endif /* __QEDR_USER_H__ */