redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ALSA: firewire-tascam: off by one in handle_midi_tx() 

My static checker complains because tscm->spec->midi_capture_ports is
either 2 or 4 but the tscm->tx_midi_substreams[] array has 4 elements so
this is possibly off by one.  I have looked at the code and I think it
should be >= instead of > as well.

Fixes: 107cc0129a ('ALSA: firewire-tascam: add support for incoming MIDI messages by asynchronous transaction')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
hifive-unleashed-5.1
Dan Carpenter 2015-10-15 21:17:11 +03:00 committed by Takashi Iwai
parent 69ec98d7e5
commit 724097059a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/firewire/tascam/tascam-transaction.c
View File

@ -158,7 +158,7 @@ static void handle_midi_tx(struct fw_card *card, struct fw_request *request,
port = b[0] >> 4;
/* TODO: support virtual MIDI ports. */
if (port > tscm->spec->midi_capture_ports)
if (port >= tscm->spec->midi_capture_ports)
goto end;
/* Assume the message length. */