redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

i2c: dev: don't start function name with 'return' 

I stumbled multiple times over 'return_i2c_dev', especially before the
actual 'return res'. It makes the code hard to read, so reanme the
function to 'put_i2c_dev' which also better matches 'get_free_i2c_dev'.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
hifive-unleashed-5.1
Wolfram Sang 2016-05-27 13:13:01 +02:00
parent d6760b14d4
commit 72a71f869c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/i2c/i2c-dev.c
View File

@ -91,7 +91,7 @@ static struct i2c_dev *get_free_i2c_dev(struct i2c_adapter *adap)
return i2c_dev;
}
static void return_i2c_dev(struct i2c_dev *i2c_dev)
static void put_i2c_dev(struct i2c_dev *i2c_dev)
{
spin_lock(&i2c_dev_list_lock);
list_del(&i2c_dev->list);
@ -575,7 +575,7 @@ static int i2cdev_attach_adapter(struct device *dev, void *dummy)
error:
cdev_del(&i2c_dev->cdev);
error_cdev:
return_i2c_dev(i2c_dev);
put_i2c_dev(i2c_dev);
return res;
}
@ -592,7 +592,7 @@ static int i2cdev_detach_adapter(struct device *dev, void *dummy)
if (!i2c_dev) /* attach_adapter must have failed */
return 0;
return_i2c_dev(i2c_dev);
put_i2c_dev(i2c_dev);
device_destroy(i2c_dev_class, MKDEV(I2C_MAJOR, adap->nr));
cdev_del(&i2c_dev->cdev);