redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

s390/cpum_sf: Assign error value to err variable

Browse source 
When starting the CPU Measurement sampling facility using
qsi() function, this function may return an error value.
This error value is referenced in the else part of the
if statement to dump its value in a debug statement.
Right now this value is always zero because it has not been
assigned a value.

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
This commit is contained in:
Thomas Richter 2019-10-31 10:38:53 +01:00 committed by Vasily Gorbik
parent c18388340c
commit 72fbcd057f
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
arch/s390/kernel/perf_cpum_sf.c
View file

@ -1007,7 +1007,8 @@ static void cpumsf_pmu_disable(struct pmu *pmu)
}
/* Save state of TEAR and DEAR register contents */
if (!qsi(&si)) {
err = qsi(&si);
if (!err) {
/* TEAR/DEAR values are valid only if the sampling facility is
* enabled. Note that cpumsf_pmu_disable() might be called even
* for a disabled sampling facility because cpumsf_pmu_enable()