procfs: Use generic_file_llseek in /proc/vmcore
/proc/vmcore has no llseek and then falls down to use default_llseek. This is racy against read_vmcore() that directly manipulates fpos but it doesn't hold the bkl there so using it in llseek doesn't protect anything. Let's use generic_file_llseek() instead. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: John Kacur <jkacur@redhat.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Al Viro <viro@ZenIV.linux.org.uk>
This commit is contained in:
parent
41775e29a7
commit
73296bc611
|
@ -162,6 +162,7 @@ static ssize_t read_vmcore(struct file *file, char __user *buffer,
|
||||||
|
|
||||||
static const struct file_operations proc_vmcore_operations = {
|
static const struct file_operations proc_vmcore_operations = {
|
||||||
.read = read_vmcore,
|
.read = read_vmcore,
|
||||||
|
.llseek = generic_file_llseek,
|
||||||
};
|
};
|
||||||
|
|
||||||
static struct vmcore* __init get_new_element(void)
|
static struct vmcore* __init get_new_element(void)
|
||||||
|
|
Loading…
Reference in a new issue