redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

V4L/DVB: si470x: -EINVAL overwritten in si470x_vidioc_s_tuner() 

This patch to the si470x_vidioc_s_tuner function was developed in
cooperation with Roel Kluin <roel.kluin@gmail.com>. It sets the default
retval to 0 instead of -EINVAL, identical to what is done in all other
set/get functions of v4l2_ioctl_ops. This is just as cosmetic change, as
retval is directly overwritten by the si470x_disconnect_check() anyway.

Signed-off-by: Tobias Lorenz <tobias.lorenz@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
hifive-unleashed-5.1
Tobias Lorenz 2010-07-10 13:01:33 -03:00 committed by Mauro Carvalho Chehab
parent 22b0766b62
commit 73c994e4fb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/radio/si470x/radio-si470x-common.c
View File

@ -748,7 +748,7 @@ static int si470x_vidioc_s_tuner(struct file *file, void *priv,
struct v4l2_tuner *tuner)
{
struct si470x_device *radio = video_drvdata(file);
int retval = -EINVAL;
int retval = 0;
/* safety checks */
retval = si470x_disconnect_check(radio);