redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

UBIFS: double check that buds are replied in order 

Commit 52c6e6f990 provides misleading infomation
in the commit messages - buds are replied in order. And the real reason why
that fix helped is probably because it made sure we seek head even in read-only
mode (so deferred recovery will have seeked heads).

This patch adds an assertion which will fire if we reply buds out of order.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
hifive-unleashed-5.1
Artem Bityutskiy 2011-05-13 16:02:19 +03:00
parent e9ef7b5f25
commit 7703f09ded
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ubifs/replay.c
View File

@ -713,6 +713,7 @@ static int replay_buds(struct ubifs_info *c)
{
struct bud_entry *b;
int err, uninitialized_var(free), uninitialized_var(dirty);
unsigned long long prev_sqnum = 0;
list_for_each_entry(b, &c->replay_buds, list) {
err = replay_bud(c, b->bud->lnum, b->bud->start, b->bud->jhead,
@ -723,6 +724,9 @@ static int replay_buds(struct ubifs_info *c)
free, dirty, b->bud->jhead);
if (err)
return err;
ubifs_assert(b->sqnum > prev_sqnum);
prev_sqnum = b->sqnum;
}
return 0;