redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

spi: pxa2xx: Drop extra check of platform_get_resource() returned value

Browse source 
The devm_ioremap_resource() has already a check for resource pointer
being NULL. No need to double check this.

Drop extra check of platform_get_resource() returned value.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20191021103625.4250-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Andy Shevchenko 2019-10-21 13:36:25 +03:00 committed by Mark Brown
parent b9fc2d207e
commit 77c544d243
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/spi/spi-pxa2xx.c
View file

@ -1545,17 +1545,15 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev)
if (!pdata) if (!pdata)
return NULL; return NULL;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return NULL;
ssp = &pdata->ssp; ssp = &pdata->ssp;
ssp->phys_base = res->start; res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ssp->mmio_base = devm_ioremap_resource(&pdev->dev, res); ssp->mmio_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(ssp->mmio_base)) if (IS_ERR(ssp->mmio_base))
return NULL; return NULL;
ssp->phys_base = res->start;
#ifdef CONFIG_PCI #ifdef CONFIG_PCI
if (pcidev_id) { if (pcidev_id) {
pdata->tx_param = pdev->dev.parent; pdata->tx_param = pdev->dev.parent;