redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

net: mvpp2: fix interrupt mask/unmask skip condition

Browse source 
The condition should be skipped if CPU ID equal to nthreads.
The patch doesn't fix any actual issue since
nthreads = min_t(unsigned int, num_present_cpus(), MVPP2_MAX_THREADS).
On all current Armada platforms, the number of CPU's is
less than MVPP2_MAX_THREADS.

Fixes: e531f76757 ("net: mvpp2: handle cases where more CPUs are available than s/w threads")
Reported-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Stefan Chulski <stefanc@marvell.com>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Stefan Chulski 2021-02-11 17:13:19 +02:00 committed by David S. Miller
parent f79bebad90
commit 7867299cde
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
View file

@ -1409,7 +1409,7 @@ static void mvpp2_interrupts_unmask(void *arg)
u32 val, thread;
/* If the thread isn't used, don't do anything */
if (cpu > port->priv->nthreads)
if (cpu >= port->priv->nthreads)
return;
thread = mvpp2_cpu_to_thread(port->priv, cpu);
@ -2595,7 +2595,7 @@ static void mvpp2_txq_sent_counter_clear(void *arg)
int queue;
/* If the thread isn't used, don't do anything */
if (smp_processor_id() > port->priv->nthreads)
if (smp_processor_id() >= port->priv->nthreads)
return;
for (queue = 0; queue < port->ntxqs; queue++) {