redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

netfilter: nf_conntrack: use hlist_add_head_rcu() in nf_conntrack_set_hashsize()

Browse source 
Using hlist_add_head() in nf_conntrack_set_hashsize() is quite dangerous.
Without any barrier, one CPU could see a loop while doing its lookup.
Its true new table cannot be seen by another cpu, but previous table is still
readable.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
This commit is contained in:
Eric Dumazet 2009-03-25 17:24:34 +01:00 committed by Patrick McHardy
parent a9a9adfe2f
commit 78f3648601
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/netfilter/nf_conntrack_core.c
View file

@ -1121,7 +1121,7 @@ int nf_conntrack_set_hashsize(const char *val, struct kernel_param *kp)
struct nf_conntrack_tuple_hash, hnode); struct nf_conntrack_tuple_hash, hnode);
hlist_del_rcu(&h->hnode); hlist_del_rcu(&h->hnode);
bucket = __hash_conntrack(&h->tuple, hashsize, rnd); bucket = __hash_conntrack(&h->tuple, hashsize, rnd);
hlist_add_head(&h->hnode, &hash[bucket]); hlist_add_head_rcu(&h->hnode, &hash[bucket]);
} }
} }
old_size = nf_conntrack_htable_size; old_size = nf_conntrack_htable_size;