redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

fs: dcache: Use true and false for boolean values 

Return statements in functions returning bool should use true or false
instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
hifive-unleashed-5.1
Gustavo A. R. Silva 2018-08-01 19:39:05 -05:00 committed by Al Viro
parent f2df5da662
commit 7964410fcf
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/dcache.c
View File

@ -732,16 +732,16 @@ static inline bool fast_dput(struct dentry *dentry)
if (dentry->d_lockref.count > 1) {
dentry->d_lockref.count--;
spin_unlock(&dentry->d_lock);
return 1;
return true;
}
return 0;
return false;
}
/*
* If we weren't the last ref, we're done.
*/
if (ret)
return 1;
return true;
/*
* Careful, careful. The reference count went down
@ -770,7 +770,7 @@ static inline bool fast_dput(struct dentry *dentry)
/* Nothing to do? Dropping the reference was all we needed? */
if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry))
return 1;
return true;
/*
* Not the fast normal case? Get the lock. We've already decremented
@ -787,7 +787,7 @@ static inline bool fast_dput(struct dentry *dentry)
*/
if (dentry->d_lockref.count) {
spin_unlock(&dentry->d_lock);
return 1;
return true;
}
/*
@ -796,7 +796,7 @@ static inline bool fast_dput(struct dentry *dentry)
* set it to 1.
*/
dentry->d_lockref.count = 1;
return 0;
return false;
}