redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

NetLabel: correct locking in selinux_netlbl_socket_setsid() 

The spinlock protecting the update of the "sksec->nlbl_state" variable is not
currently softirq safe which can lead to problems.  This patch fixes this by
changing the spin_{un}lock() functions into spin_{un}lock_bh() functions.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
hifive-unleashed-5.1
Paul Moore 2007-01-05 15:08:21 -05:00 committed by David S. Miller
parent 86112ffdcc
commit 7979512006
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
security/selinux/ss/services.c
View File

@ -2491,9 +2491,9 @@ static int selinux_netlbl_socket_setsid(struct socket *sock, u32 sid)
rc = netlbl_socket_setattr(sock, &secattr);
if (rc == 0) {
spin_lock(&sksec->nlbl_lock);
spin_lock_bh(&sksec->nlbl_lock);
sksec->nlbl_state = NLBL_LABELED;
spin_unlock(&sksec->nlbl_lock);
spin_unlock_bh(&sksec->nlbl_lock);
}
netlbl_socket_setsid_return: