gpio: tc35894: fix up tc35894 interrupt configuration
commit5.4-rM2-2.2.x-imx-squashed214b0e1ad0
upstream. The offset of regmap is incorrect, j * 8 is move to the wrong register. for example: asume i = 0, j = 1. we want to set KPY5 as interrupt falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4, this is TC3589x_GPIOIE2 not TC3589x_GPIOIBE1. Fixes:d88b25be35
("gpio: Add TC35892 GPIO driver") Cc: Cc: stable@vger.kernel.org Signed-off-by: dillon min <dillon.minfei@gmail.com> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
035f59ad4b
commit
79c8ebdce5
|
@ -209,7 +209,7 @@ static void tc3589x_gpio_irq_sync_unlock(struct irq_data *d)
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
tc3589x_gpio->oldregs[i][j] = new;
|
tc3589x_gpio->oldregs[i][j] = new;
|
||||||
tc3589x_reg_write(tc3589x, regmap[i] + j * 8, new);
|
tc3589x_reg_write(tc3589x, regmap[i] + j, new);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue