redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

xfs: fail _dir_open when readahead fails 

When we open a directory, we try to readahead block 0 of the directory
on the assumption that we're going to need it soon.  If the bmbt is
corrupt, the directory will never be usable and the readahead fails
immediately, so we might as well prevent the directory from being opened
at all.  This prevents a subsequent read or modify operation from
hitting it and taking the fs offline.

NOTE: We're only checking for early failures in the block mapping, not
the readahead directory block itself.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
hifive-unleashed-5.1
Darrick J. Wong 2017-02-02 15:13:58 -08:00
parent 4b5bd5bf3f
commit 7a652bbe36
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/xfs/libxfs/xfs_da_btree.c
View File

@ -2633,7 +2633,7 @@ out_free:
/*
* Readahead the dir/attr block.
*/
xfs_daddr_t
int
xfs_da_reada_buf(
struct xfs_inode *dp,
xfs_dablk_t bno,
@ -2664,7 +2664,5 @@ out_free:
if (mapp != &map)
kmem_free(mapp);
if (error)
return -1;
return mappedbno;
return error;
}

2
fs/xfs/libxfs/xfs_da_btree.h
View File

@ -201,7 +201,7 @@ int xfs_da_read_buf(struct xfs_trans *trans, struct xfs_inode *dp,
xfs_dablk_t bno, xfs_daddr_t mappedbno,
struct xfs_buf **bpp, int whichfork,
const struct xfs_buf_ops *ops);
xfs_daddr_t xfs_da_reada_buf(struct xfs_inode *dp, xfs_dablk_t bno,
int xfs_da_reada_buf(struct xfs_inode *dp, xfs_dablk_t bno,
xfs_daddr_t mapped_bno, int whichfork,
const struct xfs_buf_ops *ops);
int xfs_da_shrink_inode(xfs_da_args_t *args, xfs_dablk_t dead_blkno,

4
fs/xfs/xfs_file.c
View File

@ -913,9 +913,9 @@ xfs_dir_open(
*/
mode = xfs_ilock_data_map_shared(ip);
if (ip->i_d.di_nextents > 0)
xfs_dir3_data_readahead(ip, 0, -1);
error = xfs_dir3_data_readahead(ip, 0, -1);
xfs_iunlock(ip, mode);
return 0;
return error;
}
STATIC int