redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[media] v4l: vsp1: Ensure pipeline locking in resume path

Browse source 
The vsp1_pipeline_ready() and vsp1_pipeline_run() functions must be
called with the pipeline lock held, fix the resume code path.

Signed-off-by: Kieran Bingham <kieran+renesas@bingham.xyz>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Kieran Bingham 2016-09-02 07:48:27 -03:00 committed by Mauro Carvalho Chehab
parent 34e77ed84b
commit 7a9e7bd32b
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/media/platform/vsp1/vsp1_pipe.c
View file

@ -365,6 +365,7 @@ void vsp1_pipelines_suspend(struct vsp1_device *vsp1)
void vsp1_pipelines_resume(struct vsp1_device *vsp1) void vsp1_pipelines_resume(struct vsp1_device *vsp1)
{ {
unsigned long flags;
unsigned int i; unsigned int i;
/* Resume all running pipelines. */ /* Resume all running pipelines. */
@ -379,7 +380,9 @@ void vsp1_pipelines_resume(struct vsp1_device *vsp1)
if (pipe == NULL) if (pipe == NULL)
continue; continue;
spin_lock_irqsave(&pipe->irqlock, flags);
if (vsp1_pipeline_ready(pipe)) if (vsp1_pipeline_ready(pipe))
vsp1_pipeline_run(pipe); vsp1_pipeline_run(pipe);
spin_unlock_irqrestore(&pipe->irqlock, flags);
} }
} }