redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

crypto: nx - do not emit extra output if status is disabled 

If the device-tree indicates the nx-842 device's status is 'disabled',
we emit two messages:

nx_compress_pseries ibm,compression-v1: nx842_OF_upd_status: status 'disabled' is not 'okay'.
nx_compress_pseries ibm,compression-v1: nx842_OF_upd: device disabled

Given that 'disabled' is a valid state, and we are going to emit that
the device is disabled, only print out a non-'okay' status if it is not
'disabled'.

Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hifive-unleashed-5.1
Nishanth Aravamudan 2015-07-02 15:40:09 -07:00 committed by Herbert Xu
parent ec13bcbe07
commit 7abd75bf7a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/crypto/nx/nx-842-pseries.c
View File

@ -566,8 +566,14 @@ static int nx842_OF_upd_status(struct nx842_devdata *devdata,
if (!strncmp(status, "okay", (size_t)prop->length)) {
devdata->status = AVAILABLE;
} else {
dev_info(devdata->dev, "%s: status '%s' is not 'okay'\n",
/*
* Caller will log that the device is disabled, so only
* output if there is an unexpected status.
*/
if (strncmp(status, "disabled", (size_t)prop->length)) {
dev_info(devdata->dev, "%s: status '%s' is not 'okay'\n",
__func__, status);
}
devdata->status = UNAVAILABLE;
ret = -ENODEV;
}