pinctrl: samsung: Fix device node refcount leaks in S3C24xx wakeup controller init
commit5.4-rM2-2.2.x-imx-squashed6fbbcb0508
upstream. In s3c24xx_eint_init() the for_each_child_of_node() loop is used with a break to find a matching child node. Although each iteration of for_each_child_of_node puts the previous node, but early exit from loop misses it. This leads to leak of device node. Cc: <stable@vger.kernel.org> Fixes:af99a75074
("pinctrl: Add pinctrl-s3c24xx driver") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
d3d3a0bc32
commit
7b703ca18b
|
@ -490,8 +490,10 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d)
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
|
|
||||||
eint_data = devm_kzalloc(dev, sizeof(*eint_data), GFP_KERNEL);
|
eint_data = devm_kzalloc(dev, sizeof(*eint_data), GFP_KERNEL);
|
||||||
if (!eint_data)
|
if (!eint_data) {
|
||||||
|
of_node_put(eint_np);
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
}
|
||||||
|
|
||||||
eint_data->drvdata = d;
|
eint_data->drvdata = d;
|
||||||
|
|
||||||
|
@ -503,12 +505,14 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d)
|
||||||
irq = irq_of_parse_and_map(eint_np, i);
|
irq = irq_of_parse_and_map(eint_np, i);
|
||||||
if (!irq) {
|
if (!irq) {
|
||||||
dev_err(dev, "failed to get wakeup EINT IRQ %d\n", i);
|
dev_err(dev, "failed to get wakeup EINT IRQ %d\n", i);
|
||||||
|
of_node_put(eint_np);
|
||||||
return -ENXIO;
|
return -ENXIO;
|
||||||
}
|
}
|
||||||
|
|
||||||
eint_data->parents[i] = irq;
|
eint_data->parents[i] = irq;
|
||||||
irq_set_chained_handler_and_data(irq, handlers[i], eint_data);
|
irq_set_chained_handler_and_data(irq, handlers[i], eint_data);
|
||||||
}
|
}
|
||||||
|
of_node_put(eint_np);
|
||||||
|
|
||||||
bank = d->pin_banks;
|
bank = d->pin_banks;
|
||||||
for (i = 0; i < d->nr_banks; ++i, ++bank) {
|
for (i = 0; i < d->nr_banks; ++i, ++bank) {
|
||||||
|
|
Loading…
Reference in New Issue