ibmvnic: Fix unchecked return codes of memory allocations
The return values for these memory allocations are unchecked, which may cause an oops if the driver does not handle them after a failure. Fix by checking the function's return code. Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>hifive-unleashed-5.2
parent
be32a24372
commit
7c940b1a52
|
@ -428,9 +428,10 @@ static int reset_rx_pools(struct ibmvnic_adapter *adapter)
|
||||||
if (rx_pool->buff_size != be64_to_cpu(size_array[i])) {
|
if (rx_pool->buff_size != be64_to_cpu(size_array[i])) {
|
||||||
free_long_term_buff(adapter, &rx_pool->long_term_buff);
|
free_long_term_buff(adapter, &rx_pool->long_term_buff);
|
||||||
rx_pool->buff_size = be64_to_cpu(size_array[i]);
|
rx_pool->buff_size = be64_to_cpu(size_array[i]);
|
||||||
alloc_long_term_buff(adapter, &rx_pool->long_term_buff,
|
rc = alloc_long_term_buff(adapter,
|
||||||
rx_pool->size *
|
&rx_pool->long_term_buff,
|
||||||
rx_pool->buff_size);
|
rx_pool->size *
|
||||||
|
rx_pool->buff_size);
|
||||||
} else {
|
} else {
|
||||||
rc = reset_long_term_buff(adapter,
|
rc = reset_long_term_buff(adapter,
|
||||||
&rx_pool->long_term_buff);
|
&rx_pool->long_term_buff);
|
||||||
|
@ -696,9 +697,9 @@ static int init_tx_pools(struct net_device *netdev)
|
||||||
return rc;
|
return rc;
|
||||||
}
|
}
|
||||||
|
|
||||||
init_one_tx_pool(netdev, &adapter->tso_pool[i],
|
rc = init_one_tx_pool(netdev, &adapter->tso_pool[i],
|
||||||
IBMVNIC_TSO_BUFS,
|
IBMVNIC_TSO_BUFS,
|
||||||
IBMVNIC_TSO_BUF_SZ);
|
IBMVNIC_TSO_BUF_SZ);
|
||||||
if (rc) {
|
if (rc) {
|
||||||
release_tx_pools(adapter);
|
release_tx_pools(adapter);
|
||||||
return rc;
|
return rc;
|
||||||
|
|
Loading…
Reference in New Issue