1
0
Fork 0

sata_nv: give up hardreset on nf2

Kernel bz#12176 reports that nf2 hardreset simply doesn't work.  Give
up.  Argh...

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Robert Hancock <hancockr@shaw.ca>
Reported-by: Saro <saro_v@hotmail.it>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
hifive-unleashed-5.1
Tejun Heo 2009-02-12 10:34:32 +09:00 committed by Jeff Garzik
parent d1b3525b41
commit 7dac745b8e
1 changed files with 8 additions and 6 deletions

View File

@ -421,19 +421,21 @@ static struct ata_port_operations nv_generic_ops = {
.hardreset = ATA_OP_NULL, .hardreset = ATA_OP_NULL,
}; };
/* OSDL bz3352 reports that nf2/3 controllers can't determine device /* nf2 is ripe with hardreset related problems.
* signature reliably. Also, the following thread reports detection *
* failure on cold boot with the standard debouncing timing. * kernel bz#3352 reports nf2/3 controllers can't determine device
* signature reliably. The following thread reports detection failure
* on cold boot with the standard debouncing timing.
* *
* http://thread.gmane.org/gmane.linux.ide/34098 * http://thread.gmane.org/gmane.linux.ide/34098
* *
* Debounce with hotplug timing and request follow-up SRST. * And bz#12176 reports that hardreset simply doesn't work on nf2.
* Give up on it and just don't do hardreset.
*/ */
static struct ata_port_operations nv_nf2_ops = { static struct ata_port_operations nv_nf2_ops = {
.inherits = &nv_common_ops, .inherits = &nv_generic_ops,
.freeze = nv_nf2_freeze, .freeze = nv_nf2_freeze,
.thaw = nv_nf2_thaw, .thaw = nv_nf2_thaw,
.hardreset = nv_noclassify_hardreset,
}; };
/* For initial probing after boot and hot plugging, hardreset mostly /* For initial probing after boot and hot plugging, hardreset mostly