redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

netfilter: x_tables: unlock on error in xt_find_table_lock()

Browse source 
According to my static checker we should unlock here before the return.
That seems reasonable to me as well.

Fixes" b9e69e1273 ("netfilter: xtables: don't hook tables by default")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
Dan Carpenter 2017-04-28 15:57:56 +03:00 committed by Pablo Neira Ayuso
parent 9dd2ab609e
commit 7dde07e9c5
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/netfilter/x_tables.c
View file

@ -1051,8 +1051,10 @@ struct xt_table *xt_find_table_lock(struct net *net, u_int8_t af,
list_for_each_entry(t, &init_net.xt.tables[af], list) {
if (strcmp(t->name, name))
continue;
if (!try_module_get(t->me))
if (!try_module_get(t->me)) {
mutex_unlock(&xt[af].mutex);
return NULL;
}
mutex_unlock(&xt[af].mutex);
if (t->table_init(net) != 0) {