redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: dwc2: when dma is disabled, clear hcd->self.uses_dma 

When dma is disabled inside dwc2 (because the hardware does not support
it, or the code was changed to disable it for testing), let the usb core
know about this by clearing hcd->self.uses_dma.

By default, the usb core assumes that dma is used when a dma_mask is
set, but this might not always match the dma_enable value in dwc2. To
prevent problems resulting from a mismatch, better to explicitely
disable dma in this case (though everything seemed to work with the
wrong value of uses_dma as well, probably only resulted in some unneeded
work).

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
Acked-by: Paul Zimmerman <Paul.Zimmerman@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Matthijs Kooijman 2013-07-19 11:34:23 +02:00 committed by Greg Kroah-Hartman
parent a0112f4871
commit 7de76ee118
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/dwc2/hcd.c
View File

@ -2854,6 +2854,9 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq,
if (!hcd)
goto error1;
if (hsotg->core_params->dma_enable <= 0)
hcd->self.uses_dma = 0;
hcd->has_tt = 1;
spin_lock_init(&hsotg->lock);