redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: mt7621-gpio: avoid locking in mediatek_gpio_get_direction 

mediatek_gpio_get_direction function is holding across a simple read
which it seems to be not neccessary at all. Just remove this locking
cleaning code of this function a bit.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Sergio Paracuellos 2018-05-25 18:54:50 +02:00 committed by Greg Kroah-Hartman
parent e119216dea
commit 7efcce0430
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/mt7621-gpio/gpio-mt7621.c
View File

@ -129,12 +129,7 @@ static int
mediatek_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
{
struct mtk_gc *rg = to_mediatek_gpio(chip);
unsigned long flags;
u32 t;
spin_lock_irqsave(&rg->lock, flags);
t = mtk_gpio_r32(rg, GPIO_REG_CTRL);
spin_unlock_irqrestore(&rg->lock, flags);
u32 t = mtk_gpio_r32(rg, GPIO_REG_CTRL);
return (t & BIT(offset)) ? 0 : 1;
}