redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio: aspeed: fix return value check in aspeed_gpio_probe() 

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hifive-unleashed-5.1
Wei Yongjun 2016-09-15 01:30:32 +00:00 committed by Linus Walleij
parent d47529b2e9
commit 7f8b965702
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-aspeed.c
View File

@ -413,8 +413,8 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
return -ENXIO;
gpio->base = devm_ioremap_resource(&pdev->dev, res);
if (!gpio->base)
return -ENOMEM;
if (IS_ERR(gpio->base))
return PTR_ERR(gpio->base);
spin_lock_init(&gpio->lock);