redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

crypto: inside-secure - fix hash when length is a multiple of a block 

This patch fixes the hash support in the SafeXcel driver when the update
size is a multiple of a block size, and when a final call is made just
after with a size of 0. In such cases the driver should cache the last
block from the update to avoid handling 0 length data on the final call
(that's a hardware limitation).

Cc: stable@vger.kernel.org
Fixes: 1b44c5a60c ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hifive-unleashed-5.1
Antoine Ténart 2017-12-26 17:21:17 +01:00 committed by Herbert Xu
parent c957f8b3e2
commit 809778e02c
1 changed files with 24 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
drivers/crypto/inside-secure/safexcel_hash.c
View File

@ -189,17 +189,31 @@ static int safexcel_ahash_send_req(struct crypto_async_request *async, int ring,
else
cache_len = queued - areq->nbytes;
/*
* If this is not the last request and the queued data does not fit
* into full blocks, cache it for the next send() call.
*/
extra = queued & (crypto_ahash_blocksize(ahash) - 1);
if (!req->last_req && extra) {
sg_pcopy_to_buffer(areq->src, sg_nents(areq->src),
req->cache_next, extra, areq->nbytes - extra);
if (!req->last_req) {
/* If this is not the last request and the queued data does not
* fit into full blocks, cache it for the next send() call.
*/
extra = queued & (crypto_ahash_blocksize(ahash) - 1);
if (!extra)
/* If this is not the last request and the queued data
* is a multiple of a block, cache the last one for now.
*/
extra = queued - crypto_ahash_blocksize(ahash);
queued -= extra;
len -= extra;
if (extra) {
sg_pcopy_to_buffer(areq->src, sg_nents(areq->src),
req->cache_next, extra,
areq->nbytes - extra);
queued -= extra;
len -= extra;
if (!queued) {
*commands = 0;
*results = 0;
return 0;
}
}
}
spin_lock_bh(&priv->ring[ring].egress_lock);