redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

scsi: esp_scsi: Do not set SCSI message byte 

The message byte setting always devolves to COMMAND_COMPLETE so we can drop
setting the message byte in the SCSI result.

Link: https://lore.kernel.org/r/20210113090500.129644-30-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
master
Hannes Reinecke 2021-01-13 10:04:54 +01:00 committed by Martin K. Petersen
parent 6b50529e2f
commit 809dadb15a
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/scsi/esp_scsi.c
View File

@ -907,10 +907,8 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent,
esp_free_lun_tag(ent, dev->hostdata);
cmd->result = 0;
set_host_byte(cmd, host_byte);
if (host_byte == DID_OK) {
set_msg_byte(cmd, ent->message);
if (host_byte == DID_OK)
set_status_byte(cmd, ent->status);
}
if (ent->eh_done) {
complete(ent->eh_done);
@ -926,7 +924,6 @@ static void esp_cmd_is_done(struct esp *esp, struct esp_cmd_entry *ent,
*/
cmd->result = ((DRIVER_SENSE << 24) |
(DID_OK << 16) |
(COMMAND_COMPLETE << 8) |
(SAM_STAT_CHECK_CONDITION << 0));
ent->flags &= ~ESP_CMD_FLAG_AUTOSENSE;