redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[PATCH] uml: close file descriptor leaks 

Close two file descriptor leaks, one in the ubd driver and one to
/proc/mounts.  The ubd driver bug also leaked some vmalloc space.  The
/proc/mounts leak was a descriptor that was just never closed.

Signed-off-by: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
hifive-unleashed-5.1
Jeff Dike 2006-09-29 01:58:51 -07:00 committed by Linus Torvalds
parent 730760e90a
commit 80c1374914
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
arch/um/drivers/ubd_kern.c
View File

@ -668,18 +668,15 @@ static int ubd_add(int n)
if(dev->file == NULL)
goto out;
if (ubd_open_dev(dev))
goto out;
err = ubd_file_size(dev, &dev->size);
if(err < 0)
goto out_close;
goto out;
dev->size = ROUND_BLOCK(dev->size);
err = ubd_new_disk(MAJOR_NR, dev->size, n, &ubd_gendisk[n]);
if(err)
goto out_close;
goto out;
if(fake_major != MAJOR_NR)
ubd_new_disk(fake_major, dev->size, n,
@ -691,8 +688,6 @@ static int ubd_add(int n)
make_ide_entries(ubd_gendisk[n]->disk_name);
err = 0;
out_close:
ubd_close(dev);
out:
return err;
}

6
arch/um/os-Linux/mem.c
View File

@ -132,6 +132,9 @@ err:
else if(found < 0)
printf("read returned errno %d\n", -found);
out:
close(fd);
return;
found:
@ -141,11 +144,12 @@ found:
if(strncmp(buf, "tmpfs", strlen("tmpfs"))){
printf("not tmpfs\n");
return;
goto out;
}
printf("OK\n");
default_tmpdir = "/dev/shm";
goto out;
}
/*